Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3: add EventBridge notification for delete object tagging #7712

Merged

Conversation

MikiPWata
Copy link
Contributor

@MikiPWata MikiPWata commented May 21, 2024

Changes

  • s3/models.py
    • added notifications.send_event to delete_object_tagging
  • tests/test_s3/test_s3_eventbridge_integration.py
    • Added a pytest for notifications.send_event

@MikiPWata
Copy link
Contributor Author

Hey @bblommers !
Do you mind reviewing this PR whenever you have time?
thanks

Copy link
Collaborator

@bblommers bblommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @MikiPWata, this LGTM. Can you merge in the latest master? That should fix the build.

@MikiPWata
Copy link
Contributor Author

@bblommers
Thanks for the review!
gotcha

@MikiPWata MikiPWata requested a review from bblommers May 22, 2024 15:23
@MikiPWata
Copy link
Contributor Author

@bblommers
This should be ready!

Copy link
Collaborator

@bblommers bblommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome - thank you @MikiPWata!

@bblommers bblommers added this to the 5.0.8 milestone May 24, 2024
@bblommers bblommers merged commit 3308b7b into getmoto:master May 24, 2024
38 checks passed
Copy link
Contributor

This is now part of moto >= 5.0.8.dev19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants